Added svg inlining (not clean) ==> pull request#25
Open
frosini wants to merge 3 commits intokarolzak:masterfrom
Open
Added svg inlining (not clean) ==> pull request#25frosini wants to merge 3 commits intokarolzak:masterfrom
frosini wants to merge 3 commits intokarolzak:masterfrom
Conversation
frosini
force-pushed
the
svg_inlining
branch
from
a03fb2e to
2dfdfa9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @karolzak
Thanks for your answer.
This change requires urllib package (to convert the svg file in a less ambiguous way, otherwise the svg code was messing with the html). I did minimal changes to one function without changing the user functions, as i didn't want to mess with the rest of the package yet.
Please tell me if you want me to do it (i'm really afraid to do something wrong as it's the first time i do a pull request :)).
Best,
Mikael
Edit: sorry that all the tests failed, i overlooked a lot of things it seems