Add ResolveResponseStatus function to help middleware/handlers determine HTTP status code and echo.Response#2900
Open
aldas wants to merge 2 commits intolabstack:masterfrom
Open
Add ResolveResponseStatus function to help middleware/handlers determine HTTP status code and echo.Response#2900aldas wants to merge 2 commits intolabstack:masterfrom
aldas wants to merge 2 commits intolabstack:masterfrom
Conversation
…ine HTTP status code and echo.Response
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2900 +/- ##
==========================================
+ Coverage 92.94% 93.01% +0.07%
==========================================
Files 43 43
Lines 4491 4496 +5
==========================================
+ Hits 4174 4182 +8
+ Misses 197 196 -1
+ Partials 120 118 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ResolveResponseStatusfunction to help middleware/handlers determine HTTP status code and echo.Response.Loggers and tracing middlewares need to determine status code from either from error or
echo.Response. Also - response is needed often for knowing response size fromecho.Response.Size. so this function tries to shorten these 2 requirements.Relates to labstack/echo-contrib#141
and https://github.com/labstack/echo-contrib/blob/master/internal/helpers/statuscode.go
also #2892