Add additional completion to exercises that have already had their completion criteria fixed but their complete value is still wrong#5731
Open
rtibbles wants to merge 1 commit intolearningequality:hotfixesfrom
Conversation
…mpletion criteria fixed but their complete value is still wrong
rtibbles
force-pushed
the
you_complete_me
branch
from
9a8c05b to
b2984a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Further fixes to exercise completion. It appears that some are still not getting properly marked as complete, on inspection, it appears that they may already have had their completion criteria migrated by the frontend, but then never remarked as complete.
Fixes this by adding mark complete calls to all incomplete exercises.
Also adds the exercises command to the deploy step in the Makefile
References
Fixes #5667
Reviewer guidance
It is possible that this could mark otherwise "complete" exercises incomplete, should I guard against that?
AI usage
I used Claude to write the additional test, all other changes were by hand.