Handle remaining panic on persistence failure

[elnosh]

This is the only other panic! I could find related to a persistence failure. Could've used ? there to return the Err but left the match to maintain the log_error! message.

There were other panic!s during event handling such as this one:

ldk-node/src/event.rs

Lines 542 to 555 in f0338d1

	Err(err) => {
	log_error!(self.logger, "Failed to create funding transaction: {}", err);
	self.channel_manager
	.force_close_without_broadcasting_txn(
	&temporary_channel_id,
	&counterparty_node_id,
	"Failed to create funding transaction".to_string(),
	)
	.unwrap_or_else(|e| {
	log_error!(self.logger, "Failed to force close channel after funding generation failed: {:?}", e);
	panic!(
	"Failed to force close channel after funding generation failed"
	);
	});

but not related to a persistence failure so I left as is.

[G8XSU]

Overall, the diff looks good but not sure if we can mark 381 closed just with this.

[tnull]

Overall, the diff looks good but not sure if we can mark 381 closed just with this.

Yes, I agree. Generally LGTM (mod some nits), but #381 is about much more that only this case, and unfortunately we're still requiring considerable refactorings upstream on the LDK end before we can resolve all of the panic-on-persistence-failure here.

[tnull]

nit: Given this just returns the same error, replacing the unwrap_or_else with map_err instead of making this a match might be cleaner here.

[tnull]

nit: Let's just use unwrap or expect everywhere instead of assert!(..is_ok())?

[elnosh]

ok sorry about that and thank you for the clarification. Pushed other changes addressing comments from review

[tnull]

LGTM