Allow forwarding to unannounced channels if LSP service is enabled#503
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Mar 28, 2025
Merged
Conversation
joostjager
reviewed
Mar 28, 2025
joostjager
reviewed
Mar 28, 2025
| .max_inbound_htlc_value_in_flight_percent_of_channel, | ||
| 100 | ||
| ); | ||
| debug_assert!(config.accept_forwards_to_priv_channels); |
Contributor
There was a problem hiding this comment.
This seems quite defensive. Is it really needed?
Collaborator
Author
There was a problem hiding this comment.
Yup, in this case I'd prefer to make sure it is set. The issue is that we have 2-3 UserConfigs flying around now that we change depending on the context/assumptions. This is just insurance going forward that we don't change something somewhere else without keeping this use case in mind. Maybe at some point it might warrant a refactoring with some more involved config management, but I think we're not entirely there yet.
joostjager
reviewed
Mar 28, 2025
joostjager
approved these changes
Mar 28, 2025
Previously, we'd always disallow forwarding to unannounced channels. However, if we're acting as an LSP, we *should* allow forwarding to unannounced channels.
tnull
force-pushed
the
2025-03-set-priv-channel-forward-if-lsp
branch
from
6555b69 to
da5a839
Compare
Collaborator
Author
|
Squashed the fixup without further changes, going ahead landing this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #499.
Previously, we'd always disallow forwarding to unannounced channels. However, if we're acting as an LSP, we should allow forwarding to unannounced channels.