Fix: add electrs health check to prevent CI race conditions#512
Closed
alexanderwiederin wants to merge 3 commits intolightningdevkit:mainfrom
Closed
Fix: add electrs health check to prevent CI race conditions#512alexanderwiederin wants to merge 3 commits intolightningdevkit:mainfrom
alexanderwiederin wants to merge 3 commits intolightningdevkit:mainfrom
Conversation
- Add health check for electrs service in docker-compose.yml - Add explicit wait for service health in CI workflow - Prevent connection errors in tests due to services not being fully initialized This addresses intermittent CI failures where Python tests would fail with "Connection reset by peer" errors because they ran before electrs was fully ready to accept requests.
|
👋 Hi! I see this is a draft PR. |
Collaborator
|
It's a great idea to address the flaky Python CI job. Any particular reason you ended up closing this again? |
Contributor
Author
|
Sorry just saw this now. think I had a theory and wanted to test it. It didn't work out and removed the PR to not have one lingering. Reopened here #513 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses intermittent CI failures where Python tests would fail with "Connection reset by peer" errors because they ran before electrs was fully ready to accept requests.