Fix removing payment from in-memory store#514
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Apr 1, 2025
Merged
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
Mar 28, 2025
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Ah good catch indeed!
Please make these changes two commits though, and provide proper commit descriptions for both.
src/payment/store.rs
Outdated
| log_error!( | ||
| self.logger, | ||
| "Removing payment data for key {}/{}/{} failed due to: {}", | ||
| if self.payments.lock().unwrap().remove(id).is_some() { |
Collaborator
There was a problem hiding this comment.
Please introduce a variable for this, especially since it would allow us to drop the lock again before the KVStore IO operation.
src/payment/store.rs
Outdated
| .filter(f) | ||
| .cloned() | ||
| .collect::<Vec<PaymentDetails>>() | ||
| self.payments.lock().unwrap().values().filter(f).cloned().collect() |
Collaborator
There was a problem hiding this comment.
I guess, but please make this a separate commit.
src/payment/store.rs
Outdated
| Error::PersistenceFailed | ||
| })?; | ||
| Ok(()) | ||
| }) |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
andrei-21
force-pushed
the
fix/remove-payment
branch
from
2541f65 to
c32b646
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I all other places
self.paymentsstate is synchronized withself.kv_store. I guess here it should be as well, no?