fix(ci): enforce compatible CMake version for LND tests #516
fix(ci): enforce compatible CMake version for LND tests #516tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 I see @valentinewallace was un-assigned. |
moisesPompilio
force-pushed
the
issue_515
branch
from
c9480b5 to
e8dee26
Compare
moisesPompilio
changed the title
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks for looking into this! Two comments.
|
|
||
| - name: Check and install CMake if needed | ||
| # lnd_grpc_rust (via prost-build v0.10.4) requires CMake >= 3.5 but is incompatible with CMake >= 4.0. | ||
| # This step checks if CMake is missing, below 3.5, or 4.0 or higher, and installs CMake 3.31.5 if needed, |
There was a problem hiding this comment.
IIUC, 3.31.6 is the latest 3.x version?
There was a problem hiding this comment.
Yes, it's the last version before 4.x. You can check all releases here.
There was a problem hiding this comment.
Right, but you're downloading 3.31.5, not 3.31.6. Wondered if we wanted to use the latest version?
There was a problem hiding this comment.
Yes, I mistakenly added the wrong version, but I’ll update it to the latest one now.
| [ "$(cmake --version | head -n1 | cut -d' ' -f3)" \> "4.0" ]; then | ||
| sudo apt-get update | ||
| sudo apt-get remove -y cmake | ||
| wget https://github.com/Kitware/CMake/releases/download/v3.31.5/cmake-3.31.5-Linux-x86_64.sh |
There was a problem hiding this comment.
Can we verify the checksum to check we're downloading what we're expecting (similar to what we do in ./scripts/download_bitcoind_electrs.sh)?
There was a problem hiding this comment.
Yes, I’ve added checksum verification.
Ensure CMake is between 3.5 and 4.0 to prevent failures in LND integration tests caused by prost-build v0.10.4. This safeguards against version changes in ubuntu-latest. Closes lightningdevkit#515
moisesPompilio
force-pushed
the
issue_515
branch
from
e8dee26 to
d79d1ba
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM
CI failures are unrelated.
3 participants
Ensures CMake is between 3.5 and 4.0 in the CI workflow to prevent LND integration test failures caused by
prost-build v0.10.4. Since ubuntu-latest is not a fixed version, this safeguards against future runner updates that might introduce an incompatible CMake version.Closes #515.