Bitcoin payment instructions switch#546
Closed
Camillarhi wants to merge 1 commit intolightningdevkit:mainfrom
Closed
Bitcoin payment instructions switch#546Camillarhi wants to merge 1 commit intolightningdevkit:mainfrom
Camillarhi wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
…ons` from `rust-bitcoin`
559296d to
4a02cc7
Compare
tnull
reviewed
May 26, 2025
Collaborator
tnull
left a comment
There was a problem hiding this comment.
Thanks for your interest in this! As mentioned over at #521, I think it however makes sense to do this as part of/after the ongoing HRN work. So unfortunately I don't think it makes sense to just switch parts of the code over before we do the HRN integration. Going ahead and closing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR integrates the
bitcoin_payment_instructionscrate while maintaining backward compatibility:bitcoin_payment_instructionscrate for better payment URI parsingFixes #521