ci(vss): auto-extract Gradle version number ffg upgrade#593
ci(vss): auto-extract Gradle version number ffg upgrade#593tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @tnull as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Thanks! Looks good generally, some questions.
| # Print Info | ||
| java -version | ||
| gradle --version | ||
| GRADLE_VERSION=$(gradle --version | grep "Gradle" | awk '{print $2}') |
There was a problem hiding this comment.
Shouldn't we just fail here? If we can't extract the version it probably means something during the install went wrong or something unexpected happened, no? I think we should then just abort here rather than continuing with a default, which might just be confusing to debug if it ever gets hit?
| echo "Failed to extract Gradle version, using default" | ||
| GRADLE_VERSION="9.0.0-rc-1" | ||
| fi | ||
| echo $GRADLE_VERSION |
There was a problem hiding this comment.
Maybe still print the entire gradle --version in addition to the extracted value?
| # Print Info | ||
| java -version | ||
| GRADLE_VERSION=$(gradle --version | grep "Gradle" | awk '{print $2}') | ||
| GRADLE_VERSION=$(gradle --version | awk '/^Gradle/ {print $2}' | head -1) |
There was a problem hiding this comment.
Seems some of these changes should go in the first commit?
enigbe
force-pushed
the
2025-07-fix-vss-integration-ci
branch
from
0cef221 to
ef9254a
Compare
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
LGTM, feel free to squash!
enigbe
force-pushed
the
2025-07-fix-vss-integration-ci
branch
from
ef9254a to
0392313
Compare
update to Gradle 9.0 and auto-extract version number.
enigbe
force-pushed
the
2025-07-fix-vss-integration-ci
branch
from
0392313 to
8c157c3
Compare
|
Squashed! |
3 participants
What this PR does
Related Issues