Update static invoice store for invoice requests #635
Update static invoice store for invoice requests #635tnull merged 2 commits intolightningdevkit:developfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
This has the static_invoice_server test failing
I noticed that on the other PR too. Wasn't sure if it was a general flake or a specific flake. I slow do get the feeling it might be specific. |
|
Could repro locally after all. I think this may be caused by non-determinism introduced in lightningdevkit/rust-lightning#4049 where potentially two The flake disappears with lightningdevkit/rust-lightning#4046. I am going to take the easy way and won't try to debug this intermediate state of the ldk code. Closing this PR and moving the commit to #632 |
Hmm, it would be appreciated to at least somehow address the API changes on LDK main though. To get #633 to build I have to bump the tracked commit and that would include the static invoice store related API changes. |
joostjager
force-pushed
the
always-online-fwd-inv-req
branch
from
1a2335f to
54adf2f
Compare
With the merge of lightningdevkit/rust-lightning#4049, it is now possible for a static invoice server to forward the invoice request to the recipient if they are online.
joostjager
force-pushed
the
always-online-fwd-inv-req
branch
from
54adf2f to
2a912d2
Compare
|
LDK issue fixed in lightningdevkit/rust-lightning#4078 |
To better align with the expected real life setup.
joostjager
force-pushed
the
always-online-fwd-inv-req
branch
from
2a912d2 to
efbef4c
Compare
3 participants
With the merge of ttps://github.com/lightningdevkit/rust-lightning/pull/4049, it is now possible for a static invoice server to forward the invoice request to the recipient if they are online.