Add inbound channel blocking and per-peer channel limits#701
Add inbound channel blocking and per-peer channel limits#701Camillarhi wants to merge 1 commit intolightningdevkit:mainfrom
Conversation
- Add `blocked_peers` list to automatically reject channels from specific peers - Add `max_channels_per_peer` option to limit channels per peer
|
👋 I see @tnull was un-assigned. |
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 2nd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 3rd Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 4th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 5th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 6th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 7th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 8th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 9th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 10th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 11th Reminder Hey @tnull! This PR has been waiting for your review. |
|
🔔 12th Reminder Hey @tnull! This PR has been waiting for your review. |
|
Excuse the delay here, just want to explain why we didn't move forward with this yet: I think we want to hold off on this for now until we figured out how exactly the service-side API designs will change in general going forward. In particular we're planning to refactor the LSP service APIs soon to allow users more fine-grained control. Given the changes in this PR are somewhat related, we should at least ensure that the 'design language' so to speak follows the same pattern. So I'd prefer to punt on this a bit longer and then do all in one go. Hope that makes sense. |
|
Closing this for now for the above-mentioned reasons. We'll revisit when/as part of the more general LSP-interface refactor. |
Thanks, yeah this makes sense |
3 participants
This PR adds configuration options to control which peers can open inbound channels and how many channels each peer can open.
Right now, we can manually accept/reject each channel, but we don't have a way to automatically block known bad peers or stop a peer from spamming with lots of channels.
Changes
blocked_peerslist to automatically reject channels from specific peersmax_channels_per_peeroption to limit channels per peer