Skip to content

Refactoring binding python test#805

Open
heyolaniran wants to merge 6 commits intolightningdevkit:mainfrom
heyolaniran:refactoring_binding_python_test
Open

Refactoring binding python test#805
heyolaniran wants to merge 6 commits intolightningdevkit:mainfrom
heyolaniran:refactoring_binding_python_test

Conversation

@heyolaniran
Copy link

@heyolaniran heyolaniran commented Feb 24, 2026

Hello @tnull x @enigbe

In this Pull Request, I'd refactored the python binding test by introducing parallelism and by avoiding code duplication specially with event tracking and handling.

Thanks for having time to review the topic and send me a feedback if i need to make some specific action.

@ldk-reviews-bot
Copy link

ldk-reviews-bot commented Feb 24, 2026

👋 Thanks for assigning @tnull as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

@heyolaniran heyolaniran marked this pull request as draft February 24, 2026 18:37
@heyolaniran heyolaniran marked this pull request as ready for review February 24, 2026 18:40
@heyolaniran heyolaniran marked this pull request as draft February 24, 2026 19:58
@heyolaniran heyolaniran marked this pull request as draft February 24, 2026 19:58
@heyolaniran heyolaniran marked this pull request as ready for review February 24, 2026 19:58
Copy link
Collaborator

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, honestly the only real change worth considering is the move to the event_handling method (though we'd want to rename it to something like expect_event).

I'm afraid everything else here looks like unnecessary code changes that don't really do anything substantially different and hence are not worth the churn.

@heyolaniran
Copy link
Author

I understand, thanks for the review. I'll be focused on the expect event function and try to make some improvments about some cases when a specific return is expected too.

@heyolaniran heyolaniran requested a review from tnull February 25, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants