Refactoring binding python test#805
Open
heyolaniran wants to merge 6 commits intolightningdevkit:mainfrom
Open
Refactoring binding python test#805heyolaniran wants to merge 6 commits intolightningdevkit:mainfrom
heyolaniran wants to merge 6 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
Feb 25, 2026
Collaborator
tnull
left a comment
There was a problem hiding this comment.
Hmm, honestly the only real change worth considering is the move to the event_handling method (though we'd want to rename it to something like expect_event).
I'm afraid everything else here looks like unnecessary code changes that don't really do anything substantially different and hence are not worth the churn.
Author
|
I understand, thanks for the review. I'll be focused on the expect event function and try to make some improvments about some cases when a specific return is expected too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello @tnull x @enigbe
In this Pull Request, I'd refactored the python binding test by introducing parallelism and by avoiding code duplication specially with event tracking and handling.
Thanks for having time to review the topic and send me a feedback if i need to make some specific action.