Bump LDK dependency for RecipientOnionFields and SpliceFailed changes#806
Merged
tnull merged 2 commits intolightningdevkit:mainfrom Feb 25, 2026
Merged
Bump LDK dependency for RecipientOnionFields and SpliceFailed changes#806tnull merged 2 commits intolightningdevkit:mainfrom
RecipientOnionFields and SpliceFailed changes#806tnull merged 2 commits intolightningdevkit:mainfrom
Conversation
RecipientOnionFields::spontaneous_empty now takes the amount to send.
A splice's contributed inputs and outputs were moved from the SpliceFailed event to the DiscardFunding event under a new FundingInfo variant. Move the handling of reclaiming unused addresses to the DiscardFunding handler.
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
reviewed
Feb 25, 2026
Collaborator
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Looks good, mod one comment.
@benthecarman Do you intend to open a follow-up PR that actually adds new APIs making use of the RecipientOnionFields changes?
| output: outputs, | ||
| }; | ||
| if let Err(e) = self.wallet.cancel_tx(&tx) { | ||
| log_error!(self.logger, "Failed reclaiming unused addresses: {}", e); |
Collaborator
There was a problem hiding this comment.
Hmm, I think we should log that persistence failed here, as this is also why we replay the event. Otherwise we probably shouldn't replay.
Contributor
Author
There was a problem hiding this comment.
Wallet::cancel_tx already logs that.
tnull
approved these changes
Feb 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps the LDK dependency to include changes to the
RecipientOnionFieldsconstructor (lightningdevkit/rust-lightning#4373) andSpliceFailedevent (lightningdevkit/rust-lightning#4388).