Drop spurious debug assertion in sweeping logic#3524
Merged
tnull merged 1 commit intolightningdevkit:mainfrom Jan 13, 2025
Merged
Drop spurious debug assertion in sweeping logic#3524tnull merged 1 commit intolightningdevkit:mainfrom
tnull merged 1 commit intolightningdevkit:mainfrom
Conversation
With the `Confirm` interface, transaction confirmations can come in at any time, so asserting that a confirmation is more recent than the last time we broadcasted a transaction can lead to spurious assertion failures.
tnull
approved these changes
Jan 13, 2025
Contributor
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
I think we really need to rewrite Confirm to fix this properly, but this makes sense as an intermittent fix. Going ahead and landing this.
Collaborator
Author
|
Backported in #3536. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the
Confirminterface, transaction confirmations can come in at any time, so asserting that a confirmation is more recent than the last time we broadcasted a transaction can lead to spurious assertion failures.