Note the mempool policy requirements of zero-fee commitment channels#4187
Merged
TheBlueMatt merged 1 commit intolightningdevkit:mainfrom Oct 29, 2025
Merged
Conversation
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4187 +/- ##
==========================================
+ Coverage 88.86% 88.87% +0.01%
==========================================
Files 180 180
Lines 137869 137863 -6
Branches 137869 137863 -6
==========================================
+ Hits 122520 122531 +11
+ Misses 12539 12523 -16
+ Partials 2810 2809 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheBlueMatt
reviewed
Oct 29, 2025
lightning/src/util/config.rs
Outdated
| /// is set) or `static_remote_key` channel. | ||
| /// | ||
| /// To have confidence that a force-close transaction will reach miners and get confirmed, | ||
| /// zero-fee commitment channels require your Bitcoin node **and some of its peers** to |
Collaborator
There was a problem hiding this comment.
Might be worth being explicit that there needs to be a path between your node and miners running 29+.
tankyleo
force-pushed
the
25-10-0FC-requires-v29
branch
from
13a5269 to
30e3bdc
Compare
tankyleo
force-pushed
the
25-10-0FC-requires-v29
branch
from
30e3bdc to
426c881
Compare
Merged
Collaborator
|
Backported to 0.2 in #4193 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.