Include monitor name in error when failing to load a monitor#4192
Include monitor name in error when failing to load a monitor#4192TheBlueMatt merged 1 commit intolightningdevkit:mainfrom
Conversation
|
I've assigned @valentinewallace as a reviewer! |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
|
Oh, |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4192 +/- ##
==========================================
- Coverage 88.87% 88.86% -0.01%
==========================================
Files 180 180
Lines 137876 137879 +3
Branches 137876 137879 +3
==========================================
- Hits 122532 122531 -1
+ Misses 12543 12542 -1
- Partials 2801 2806 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If we fail to load a `ChannelMonitor` due to the new limits in LDK 0.2, its useful to communicate which monitor failed, which we do here. Requested at lightningdevkit#4146 (comment)
TheBlueMatt
force-pushed
the
2025-10-mon-err-print
branch
from
52b42cd to
a4f4663
Compare
|
Grr, I ran it locally and it didn't complain. |
|
Backported to 0.2 in #4193 |
3 participants
If we fail to load a
ChannelMonitordue to the new limits in LDK 0.2, its useful to communicate which monitor failed, which we do here.Requested at
#4146 (comment)