Improve block connection logging for easier debugging

.github/workflows/build.yml

@@ -30,8 +30,14 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        platform: [ self-hosted, windows-latest, macos-latest ]
-        toolchain: [ stable, beta, 1.75.0 ] # 1.75.0 is the MSRV for all crates
+        platform: >-
+          ${{ github.event_name == 'push' && github.ref == 'refs/heads/main'
+            && fromJSON('["self-hosted","windows-latest","macos-latest"]')
+            || fromJSON('["self-hosted"]') }}
+        toolchain: >-
+          ${{ github.event_name == 'push' && github.ref == 'refs/heads/main'
+            && fromJSON('["stable","beta","1.75.0"]')
+            || fromJSON('["1.75.0"]') }}
         exclude:
           - platform: windows-latest
             toolchain: 1.75.0
@@ -62,52 +68,35 @@ jobs:
       - name: Set RUSTFLAGS to deny warnings
         if: "matrix.toolchain == '1.75.0'"
         run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
-      - name: Run CI script
-        shell: bash # Default on Winblows is powershell
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh
-
-  build-tx-sync:
-    strategy:
-      fail-fast: false
-      matrix:
-        platform: [ ubuntu-latest, macos-latest ]
-        toolchain: [ stable, beta, 1.75.0 ]
-    runs-on: ${{ matrix.platform }}
-    steps:
-      - name: Checkout source code
-        uses: actions/checkout@v4
-      - name: Install Rust ${{ matrix.toolchain }} toolchain
-        run: |
-          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ matrix.toolchain }}
-      - name: Set RUSTFLAGS to deny warnings
-        if: "matrix.toolchain == '1.75.0'"
-        run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
       - name: Enable caching for bitcoind
+        if: matrix.platform != 'windows-latest'
         id: cache-bitcoind
         uses: actions/cache@v4
         with:
           path: bin/bitcoind-${{ runner.os }}-${{ runner.arch }}
           key: bitcoind-${{ runner.os }}-${{ runner.arch }}
       - name: Enable caching for electrs
+        if: matrix.platform != 'windows-latest'
         id: cache-electrs
         uses: actions/cache@v4
         with:
           path: bin/electrs-${{ runner.os }}-${{ runner.arch }}
           key: electrs-${{ runner.os }}-${{ runner.arch }}
       - name: Download bitcoind/electrs
-        if: "steps.cache-bitcoind.outputs.cache-hit != 'true' || steps.cache-electrs.outputs.cache-hit != 'true'"
+        if: "matrix.platform != 'windows-latest' && (steps.cache-bitcoind.outputs.cache-hit != 'true' || steps.cache-electrs.outputs.cache-hit != 'true')"
         run: |
             source ./contrib/download_bitcoind_electrs.sh
             mkdir bin
             mv "$BITCOIND_EXE" bin/bitcoind-${{ runner.os }}-${{ runner.arch }}
             mv "$ELECTRS_EXE" bin/electrs-${{ runner.os }}-${{ runner.arch }}
       - name: Set bitcoind/electrs environment variables
+        if: matrix.platform != 'windows-latest'
         run: |
             echo "BITCOIND_EXE=$( pwd )/bin/bitcoind-${{ runner.os }}-${{ runner.arch }}" >> "$GITHUB_ENV"
             echo "ELECTRS_EXE=$( pwd )/bin/electrs-${{ runner.os }}-${{ runner.arch }}" >> "$GITHUB_ENV"
       - name: Run CI script
         shell: bash # Default on Winblows is powershell
-        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tx-sync-tests.sh
+        run: CI_ENV=1 CI_MINIMIZE_DISK_USAGE=1 ./ci/ci-tests.sh
 
   coverage:
     needs: fuzz
@@ -337,3 +326,19 @@ jobs:
         run: cargo fmt --check
       - name: Run rustfmt checks on lightning-tests
         run: cd lightning-tests && cargo fmt --check
+  tor-connect:
+    runs-on: ubuntu-latest
+    env:
+      TOOLCHAIN: 1.75.0
+    steps:
+      - name: Checkout source code
+        uses: actions/checkout@v4
+      - name: Install tor
+        run: |
+          sudo apt install -y tor
+      - name: Install Rust ${{ env.TOOLCHAIN }} toolchain
+        run: |
+          curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
+      - name: Test tor connections using lightning-net-tokio
+        run: |
+          TOR_PROXY="127.0.0.1:9050" RUSTFLAGS="--cfg=tor" cargo test --verbose --color always -p lightning-net-tokio

.github/workflows/ldk-node-integration.yml

@@ -39,6 +39,19 @@ jobs:
             lightning-transaction-sync = { path = "../rust-lightning/lightning-transaction-sync" }
             lightning-liquidity = { path = "../rust-lightning/lightning-liquidity" }
             lightning-macros = { path = "../rust-lightning/lightning-macros" }
+
+            [patch."https://github.com/lightningdevkit/rust-lightning"]
+            lightning = { path = "../rust-lightning/lightning" }
+            lightning-types = { path = "../rust-lightning/lightning-types" }
+            lightning-invoice = { path = "../rust-lightning/lightning-invoice" }
+            lightning-net-tokio = { path = "../rust-lightning/lightning-net-tokio" }
+            lightning-persister = { path = "../rust-lightning/lightning-persister" }
+            lightning-background-processor = { path = "../rust-lightning/lightning-background-processor" }
+            lightning-rapid-gossip-sync = { path = "../rust-lightning/lightning-rapid-gossip-sync" }
+            lightning-block-sync = { path = "../rust-lightning/lightning-block-sync" }
+            lightning-transaction-sync = { path = "../rust-lightning/lightning-transaction-sync" }
+            lightning-liquidity = { path = "../rust-lightning/lightning-liquidity" }
+            lightning-macros = { path = "../rust-lightning/lightning-macros" }
           EOF
           cargo check
           cargo check --features uniffi

.github/workflows/semver.yml

@@ -17,40 +17,9 @@ jobs:
         run: |
           curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
           rustup override set stable
-      - name: Check SemVer with default features
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            feature-group: default-features
-      - name: Check SemVer *without* default features
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            feature-group: only-explicit-features
-      - name: Check lightning-background-processor SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            package: lightning-background-processor
-            feature-group: only-explicit-features
-      - name: Check lightning-block-sync SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            package: lightning-block-sync
-            feature-group: only-explicit-features
-            features: rpc-client,rest-client
-      - name: Check lightning-transaction-sync electrum SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            manifest-path: lightning-transaction-sync/Cargo.toml
-            feature-group: only-explicit-features
-            features: electrum
-      - name: Check lightning-transaction-sync esplora-blocking SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            manifest-path: lightning-transaction-sync/Cargo.toml
-            feature-group: only-explicit-features
-            features: esplora-blocking
-      - name: Check lightning-transaction-sync esplora-async SemVer
-        uses: obi1kenobi/cargo-semver-checks-action@v2
-        with:
-            manifest-path: lightning-transaction-sync/Cargo.toml
-            feature-group: only-explicit-features
-            features: esplora-async
+      - name: Install SemVer Checker
+        run: cargo install cargo-semver-checks --locked
+      - name: Check SemVer with all features
+        run: cargo semver-checks
+      - name: Check SemVer without any non-default features
+        run: cargo semver-checks --only-explicit-features

.gitignore

@@ -16,3 +16,4 @@ lightning-dns-resolver/target
 ext-functional-test-demo/target
 no-std-check/target
 msrv-no-dev-deps-check/target
+lightning-tests/target

CHANGELOG.md

@@ -1,3 +1,29 @@
+# 0.2.1 - Jan 29, 2025 - "Electrum Confirmations Logged"
+
+## API Updates
+ * The `AttributionData` struct is now public, correcting an issue where it was
+   accidentally sealed preventing construction of some messages (#4268).
+ * The async background processor now exits even if work remains to be done as
+   soon as the sleeper returns the exit flag (#4259).
+
+## Bug Fixes
+ * The presence of unconfirmed transactions no longer causes
+   `ElectrumSyncClient` to spuriously fail to sync (#4341).
+ * `ChannelManager::splice_channel` now properly fails immediately if the
+   peer does not support splicing (#4262, #4274).
+ * A spurious debug assertion was removed which could fail in cases where an
+   HTLC fails to be forwarded after being accepted (#4312).
+ * Many log calls related to outbound payments were corrected to include a
+   `payment_hash` field (#4342).
+
+
+# 0.1.9 - Jan 26, 2026 - "Electrum Confirmations"
+
+## Bug Fixes
+ * The presence of unconfirmed transactions no longer causes
+   `ElectrumSyncClient` to spuriously fail to sync (#4341).
+
+
 # 0.2 - Dec 2, 2025 - "Natively Asynchronous Splicing"
 
 ## API Updates

CLAUDE.md

@@ -0,0 +1,21 @@
+# CLAUDE.md
+
+This file provides guidance to Claude Code (claude.ai/code) when working with code in this repository.
+
+See [CONTRIBUTING.md](CONTRIBUTING.md) for build commands, testing, code style, and development workflow.
+
+## Workspace Structure
+
+See [README.md](README.md) for the workspace layout and [ARCH.md](ARCH.md) for some additional remark regarding important parts of LDK's architecture.
+
+## Development Rules
+
+- Always ensure tests pass before committing. To this end, you should run
+  `cargo +1.75.0 test` for all affected crates and/or features. Upon completion
+  of the full task you might prompt the user whether they want you to run the
+  full CI tests via `./ci/ci-tests.sh`. Note however that this script will run
+  for a very long time, so please don't timeout when you do.
+- Run `cargo +1.75.0 fmt --all` after every code change
+- Never add new dependencies unless explicitly requested
+- Please always disclose the use of any AI tools in commit messages and PR descriptions using a `Co-Authored-By:` line.
+- When adding new `.rs` files, please ensure to always add the licensing header as found, e.g., in `lightning/src/lib.rs` and other files.

CONTRIBUTING.md

@@ -176,6 +176,28 @@ Fuzzing is heavily encouraged: you will find all related material under `fuzz/`
 Mutation testing is work-in-progress; any contribution there would be warmly
 welcomed.
 
+### Environment Variables
+
+* `LDK_TEST_CONNECT_STYLE` - Override the random block connect style used in tests for deterministic runs. Valid values:
+  * `BEST_BLOCK_FIRST`
+  * `BEST_BLOCK_FIRST_SKIPPING_BLOCKS`
+  * `BEST_BLOCK_FIRST_REORGS_ONLY_TIP`
+  * `TRANSACTIONS_FIRST`
+  * `TRANSACTIONS_FIRST_SKIPPING_BLOCKS`
+  * `TRANSACTIONS_DUPLICATIVELY_FIRST_SKIPPING_BLOCKS`
+  * `HIGHLY_REDUNDANT_TRANSACTIONS_FIRST_SKIPPING_BLOCKS`
+  * `TRANSACTIONS_FIRST_REORGS_ONLY_TIP`
+  * `FULL_BLOCK_VIA_LISTEN`
+  * `FULL_BLOCK_DISCONNECTIONS_SKIPPING_VIA_LISTEN`
+
+* `LDK_TEST_DETERMINISTIC_HASHES` - When set to `1`, uses deterministic hash map iteration order in tests. This ensures consistent test output across runs, useful for comparing logs before and after changes.
+
+* `LDK_TEST_REBUILD_MGR_FROM_MONITORS` - If set to `1`, on test node reload the `ChannelManager`'s
+  HTLC set will be reconstructed from `Channel{Monitor}` persisted data. If `0`, test nodes will be
+  reloaded from persisted `ChannelManager` data using legacy code paths. This ensures consistent
+  test output across runs, useful for comparing logs before and after changes, since otherwise the
+  selection of which codepaths to be used on reload will be chosen randomly.
+
 C/C++ Bindings
 --------------
 

Cargo.toml

@@ -16,11 +16,11 @@ members = [
     "lightning-macros",
     "lightning-dns-resolver",
     "lightning-liquidity",
+    "lightning-transaction-sync",
     "possiblyrandom",
 ]
 
 exclude = [
-    "lightning-transaction-sync",
     "lightning-tests",
     "ext-functional-test-demo",
     "no-std-check",
@@ -67,4 +67,5 @@ check-cfg = [
     "cfg(require_route_graph_test)",
     "cfg(simple_close)",
     "cfg(peer_storage)",
+    "cfg(tor)",
 ]

ci/check-lint.sh

@@ -13,6 +13,7 @@ CLIPPY() {
 		-A clippy::unwrap-or-default \
 		-A clippy::upper_case_acronyms \
 		-A clippy::swap-with-temporary \
+		-A clippy::assertions-on-constants \
 		`# Things where we do odd stuff on purpose ` \
 		-A clippy::unusual_byte_groupings \
 		-A clippy::unit_arg \
@@ -107,7 +108,8 @@ CLIPPY() {
 		-A clippy::useless_conversion \
 		-A clippy::manual_repeat_n `# to be removed once we hit MSRV 1.86` \
 		-A clippy::manual_is_multiple_of `# to be removed once we hit MSRV 1.87` \
-		-A clippy::uninlined-format-args
+		-A clippy::uninlined-format-args \
+		-A clippy::manual-async-fn # Not really sure why this is even a warning when there's a Send bound
 }
 
 CLIPPY