Check that funder covers the fee spike buffer multiple after a splice#4433
Check that funder covers the fee spike buffer multiple after a splice#4433tankyleo wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
tankyleo
force-pushed
the
2026-02-splice-assertions
branch
from
ed77b45 to
9035906
Compare
Notably, if a party splices funds into the channel, their new balance must be above the new reserve.
We do this for HTLCs, so we should also do this for splices. This applies to `only_static_remote_key` channels alone.
tankyleo
force-pushed
the
2026-02-splice-assertions
branch
from
9035906 to
1959d52
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4433 +/- ##
==========================================
+ Coverage 85.87% 85.90% +0.02%
==========================================
Files 157 159 +2
Lines 103769 104315 +546
Branches 103769 104315 +546
==========================================
+ Hits 89115 89613 +498
- Misses 12158 12203 +45
- Partials 2496 2499 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| 1 | ||
| }; | ||
|
|
||
| let feerate_per_kw = if !funding.get_channel_type().supports_anchors_zero_fee_htlc_tx() { |
There was a problem hiding this comment.
Shouldn't this be funding.get_channel_type() == ChannelTypeFeatures::only_static_remote_key?
| // 4) Try again with the additional satoshi removed from the splice-out message, and check that it passes | ||
| // validation on the receiver's side. | ||
|
|
||
| let (preimage_1_to_0_d, node_1_real_splice_out) = { |
There was a problem hiding this comment.
Can we not DRY this up with the presage_0_to_1_d block below?
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
3 participants
and