[test][improvement] Standardize bash error handling and add CCM log collection for e2e tests #523
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR improves the reliability and debuggability of our e2e test suite by:
set -etoset -euo pipefailChanges
Bash Error Handling Standardization
set -ewithset -euo pipefailin all script blocksset -euo pipefailprovides:-e: Exit on any command failure-u: Treat unset variables as errors-o pipefail: Exit if any command in a pipeline failsCCM Log Collection on Failure
catchblocks to all 47 e2e testskubectl logs -n kube-system daemonsets/ccm-linode | grep "<test-namespace>" | tail -100Impact
Files Changed
e2e/test/,e2e/bgp-test/, ande2e/subnet-test/Testing