Align GHA workflows in the scope of report uploads #640
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mawilk90
requested review from
jriddle-linode and
lgarber-akamai
and removed request for
a team
mawilk90
force-pushed
the
hotfix/align_report_uploads
branch
from
f685e80 to
465f35f
Compare
mawilk90
added
the
improvement
Contributor
There was a problem hiding this comment.
Pull request overview
This PR restricts test result uploads to TOD to only occur during push and pull request events, excluding manual workflow dispatch runs. This aligns integration test workflows with the standard GHA workflow behavior for report uploads.
Changes:
- Modified
e2e-test.ymlto only upload reports on push events - Modified
e2e-test-pr.ymlto only upload reports on pull request events
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.github/workflows/e2e-test.yml |
Added github.event_name == 'push' condition to prevent report uploads on manual workflow runs |
.github/workflows/e2e-test-pr.yml |
Added github.event_name == 'pull_request' condition to prevent report uploads on manual workflow runs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Description
GHA workflows upload test results to TOD on push, PR and manual (workflow_dispatch) - aligning integration test workflows to upload results on push and/or PR only.
https://track.akamai.com/jira/browse/TPT-4190
✔️ How to Test
Manual run of workflows should not upload test results to TOD.