Conversation
|
⚡️ Running CI build with LocalStack ... |
e7ed2ab to
8e4b4e6
Compare
| MIT License | ||
|
|
||
| Copyright (c) 2022 Harsh Mishra | ||
| Copyright (c) 2022-2026 LocalStack |
There was a problem hiding this comment.
Q: is that the right way to do it? Happy to change it back, but I guess as we have the action in the organization it makes more sense to use "LocalStack"?
There was a problem hiding this comment.
Yes, looks good to me! Imho this is only there for historical reasons, the action was handed over from @HarshCasper early after the initial creation. However, maybe we could just adjust it according to @HarshCasper's directions in a follow up.
alexrashed
left a comment
There was a problem hiding this comment.
Nice! The action is getting cleaner and cleaner with every PR! The changes here are looking good to me!
However, you mentioned in the PR description that this PR should contain some GitHub action digest updates, even though I couldn't see them in the changeset. Has this been superseded, or did I miss it? :)
| MIT License | ||
|
|
||
| Copyright (c) 2022 Harsh Mishra | ||
| Copyright (c) 2022-2026 LocalStack |
There was a problem hiding this comment.
Yes, looks good to me! Imho this is only there for historical reasons, the action was handed over from @HarshCasper early after the initial creation. However, maybe we could just adjust it according to @HarshCasper's directions in a follow up.
I updated the description a couple of times to reflect the actual changes, maybe it was an outdated description version? It's currently listed under "followup tasks": |
General cleanup:
descriptionto theaction.ymlfilessecrets.LOCALSTACK_API_KEYwithsecrets.LOCALSTACK_AUTH_TOKENFollowup tasks
ephemeral feature:
emphermal.yml(api seems to have issues currently though)check and potentially update other third party actions