make the NUKE_CERT variables case insensitive#528
Draft
marionbarker wants to merge 1 commit intodevfrom
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Make the ENABLE_NUKE_CERTS and FORCE_NUKE_CERTS variables case insensitive.
trueTrueto be entered unless special care is takenSeveral people have needed help to change their entries from
TruetotrueThis PR solves the issue.
Method
Convert the variables to lower case internally before using them.
In addition, I changed var.FORCE_NUKE_CERTS to be treated like ENABLE_NUKE_CERTS
Test
Test using dev branch and this PR to observe the effect of
true,TrueandTRUE.Realized during full testing that the FORCE_NUKE_CERT was already case insensitive with respect to whether nuking is forced
Upon closer inspection, the messages are handled in one bit of the code and the action is handled in a different bit of the code. This only modifies the part of the code with the messages in
name: Set output and annotations based on Fastlane resultin thecreate_certsjob. It does not affect the code innuke_certsjob.Nuke certificates
✅ But don't worry about your existing TestFlight builds, they will keep working!
other expected messages
Nuke certificates]
✅ But don't worry about your existing TestFlight builds, they will keep working!