This repository was archived by the owner on Sep 10, 2023. It is now read-only.
Open
Conversation
Change of keydown event handler to a keyup event handler due to issues with mobile Safari not displaying the suggestion list loaded from AJAX request. Cause being the keydown event fires before the character is entered into the input and so the AJAX response query differs from the input term when processing the AJAX response.
Mobile Safari stops focus being set when outside a user event, hence when set from inside the setTimeout function, it fails to set the focus
fd2316b to
8a8390e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes for setting focus and showing suggestions from AJAX request