Don't conflate coordinates and waypoints

[dudeuter]

Description

Fixes issues with silent waypoints, routes from the EV route planner, and BYOR.

[codecov]

Codecov Report

Merging #6507 (429d614) into main (8273101) will not change coverage.
The diff coverage is 66.66%.

@@            Coverage Diff            @@
##               main    #6507   +/-   ##
=========================================
  Coverage     70.33%   70.33%           
  Complexity     4909     4909           
=========================================
  Files           717      717           
  Lines         27950    27950           
  Branches       3295     3295           
=========================================
  Hits          19659    19659           
  Misses         7013     7013           
  Partials       1278     1278           

Impacted Files	Coverage Δ
.../navigation/core/trip/session/MapboxTripSession.kt	86.64% <66.66%> (ø)

[LukasPaczos]

Tagging @RingerJK as you've been working on #6005 which essentially tackles the same problem (and more).

[RingerJK]

#6005 is ready for review, we should be good to close this one if merge #6005

[kmadsen]

@dudeuter will you add tests for this?

[dudeuter]

@dudeuter will you add tests for this?

@RingerJK's work will make this change unnecessary in v2.9+ I was working on this as more of a workaround for this part of the Java SDK not decoding the URL properly.

We might want to update the RouteOptions index URL Path parameters starting from the end. Which might make the decode method a little more robust.

List<String> pathElements = Arrays.asList(url.getPath().split("/"));
Collections.reverse(pathElements);

optionsJson.addProperty("coordinates", URLDecoder.decode(pathElements.get(0), UTF_8));
optionsJson.addProperty("profile", URLDecoder.decode(pathElements.get(1), UTF_8));
optionsJson.addProperty("user", URLDecoder.decode(pathElements.get(2), UTF_8));

That way if anyone's messing around with the basepath they'll be more likely to correctly parse their coordinates, and they can next their API as many arbitrary paths as they want.

[LukasPaczos]

Since #6005 landed, changes here are not needed anymore.

@dudeuter let's start a separate ticket/PR if you think we should make any changes to how we parse URLs.