Conversation
lachiebol
changed the title
| if (typeof SwaggerUIBundle === 'function') { | ||
| SwaggerUIBundle({ | ||
| dom_id: '#swagger-ui', | ||
| url: '/openapi/matomo_openapi_spec_v1.0.0.json', |
There was a problem hiding this comment.
@lachiebol This should ideally come from a demo URL right ?
There was a problem hiding this comment.
@AltamashShaikh Oh will we grab from demo using the OpenApiDocs API?
I might need to do a separate PR to let us get the generated version in OpenApiDocs. Currently the API method generates a spec only for one plugin, and does it every time the endpoint is hit
There was a problem hiding this comment.
@lachiebol How are you planning to keep this updated ?
There was a problem hiding this comment.
@AltamashShaikh That was a thought I was having while doing this, so I think having it be from demo would make sense. We could have some process that regenerates the spec
There was a problem hiding this comment.
Yes a command which cloud team can run after deployment
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
@lachiebol The plugin names should be ordered alphabetically I think
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
The UI doesn't look great, but this PR does what is required.
@AltamashShaikh I decided to keep styling pretty much out of the box, since this page isn't public and we have a future ticket for doing the theme https://innocraft.atlassian.net/browse/PG-4594 |
AltamashShaikh
left a comment
AltamashShaikh
left a comment
There was a problem hiding this comment.
Looks good now :)
2 participants
Description
Hidden page, can be found at /api-reference-swagger
Haven't done much css just some basic touch ups, theming to be done in https://innocraft.atlassian.net/browse/PG-4594
Checklist
Review