Merged
Conversation
Member
oschwald
commented
Dec 8, 2025
oschwald
commented
- Update maxmind-db dependency to 4.0.2
- Add test to verify all database records deserialize correctly
This fixes a bug where enums with @MaxMindDbCreator would throw ConstructorNotFoundException when data was stored via a pointer in the database. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This test iterates over every network in each test database and performs a lookup to ensure no deserialization errors occur. It catches issues with pointer-based deduplication and other edge cases. Based on the reproduction test from GitHub issue #644. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
oschwald
force-pushed
the
greg/eng-3612
branch
from
90585f6 to
cd2ccc6
Compare
horgh
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.