[WTF] Migrate The Repository to React 19 & React Native 0.78.2 by LEGIO-SEXTA-FERRATA · Pull Request #163 · mendix/widgets-tools

LEGIO-SEXTA-FERRATA · 2026-02-17T06:48:53Z

This is no longer a test PR but is supposed to replace this.

packages/pluggable-widgets-tools/configs/tsconfig.base.json

packages/pluggable-widgets-tools/utils/migration.js

alihcsumer · 2026-02-25T14:26:14Z

packages/command-tests/commands.js

+    // ["web", "full", "ts", "8.0"],
+    // ["native", "full", "ts", "8.6"],
+    // ["web", "full", "ts", "8.6"],
+    // ["web", "full", "js", "8.7"],
+    // ["web", "full", "ts", "8.9"],
+    // ["native", "full", "ts", "8.9"],


I suppose it is forgotten.

To Ali's point, shouldn't this be deleted?

…will become unused

weirdwater · 2026-02-27T14:41:33Z

To allow this PR to merge I updated the branch protection rules to remove the requirement that the node 16 tests succeed. After merge we should update them to require that the node 20 tests succeed.

weirdwater · 2026-02-27T14:50:15Z

.github/workflows/TestPWTCommands.yml

      - name: Setup pnpm
        uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda #v4.1.0
        if: matrix.node == 16
        with:
          version: 8
      - name: Setup pnpm
        uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda #v4.1.0
        if: matrix.node == 18
        with:
          version: 10
+      - name: Setup pnpm
+        uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda #v4.1.0
+        if: matrix.node == 20
+        with:
+          version: 10


We can reduce these to a single Setup pnpm step, as pnpm 10 supports both node 18 and 20.

- name: Setup pnpm uses: pnpm/action-setup@a7487c7e89a18df4991f7f222e4898a00d66ddda #v4.1.0 with: version: 10

weirdwater · 2026-02-27T14:53:21Z

packages/command-tests/commands.js

+    // ["web", "full", "ts", "8.0"],
+    // ["native", "full", "ts", "8.6"],
+    // ["web", "full", "ts", "8.6"],
+    // ["web", "full", "js", "8.7"],
+    // ["web", "full", "ts", "8.9"],
+    // ["native", "full", "ts", "8.9"],


To Ali's point, shouldn't this be deleted?

weirdwater · 2026-02-27T14:56:16Z

packages/generator-widget/generators/app/templates/packages/package_web.json.ejs

+    "react-dom": "^19.0.0",<% if (isLanguageTS) { %>
+    "@types/react": "^19.0.0",
+    "@types/react-dom": "^19.0.0",<% } %>
+    "react-native": "~0.78.2"


Do we need react native in the web package.json template?

weirdwater · 2026-02-27T14:58:15Z

.../templates/pluggable/native/emptyTemplateJs/src/components/__tests__/HelloWorld.spec.jsx.ejs

@@ -1,4 +1,4 @@
-import { createElement } from "react";
+


This and a lot of other template files have an empty line, where the React import used to only import createElement. Can you remove these empty first lines?

weirdwater · 2026-02-27T15:01:20Z

...widget/generators/app/templates/pluggable/native/fullTemplateTs/src/components/Badge.tsx.ejs

+        ) as ReactNode;
    }



The need to cast these JSX expressions tells me the typings are not well aligned. I also remember from upgrading the client that we would use JSX.Element instead of ReactNode.

weirdwater · 2026-02-27T15:08:35Z

packages/pluggable-widgets-tools/configs/eslint.js.base.json

-            "warn",
-            {
-                "varsIgnorePattern": "createElement",
-                "args": "none"


In my previous comment I suggested to remove this object from the rule's configuration. However, I missed that this args setting is separate from the createElement exception. So we may want to re-introduce it.

weirdwater · 2026-02-27T15:12:32Z

packages/pluggable-widgets-tools/configs/eslint.ts.base.json

-            }
-        ],
-        "@typescript-eslint/ban-types": "warn",
+        "no-unused-vars": "warn",


The authors of typescript-eslint recommend to disable no-unused-vars as it may report false positives in combination with @typescript-eslint/no-unused-vars.

weirdwater · 2026-02-27T15:15:15Z

packages/pluggable-widgets-tools/configs/eslint.ts.base.json

        "@typescript-eslint/class-name-casing": "off",
        "@typescript-eslint/indent": "off",
        "@typescript-eslint/no-object-literal-type-assertion": "off",
+        "@typescript-eslint/no-require-imports": "warn",


Does this change downgrade or start reporting require imports?

weirdwater · 2026-02-27T15:19:24Z

packages/pluggable-widgets-tools/package.json

    "@types/testing-library__jest-dom": "^5.14.5",
-    "@typescript-eslint/eslint-plugin": "^5.8.1",
-    "@typescript-eslint/parser": "^5.8.1",
+    "@typescript-eslint/eslint-plugin": "^8.0.0",


The autofix command added to the migration script relies on a feature that was added to the eslint plugin in 8.53.0, so we should increase the minimum version to at least that.

LEGIO-SEXTA-FERRATA self-assigned this Feb 17, 2026

LEGIO-SEXTA-FERRATA requested a review from a team as a code owner February 17, 2026 06:48

mendix-widgets-framework added generator-widget pluggable-widgets-tools labels Feb 17, 2026

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch 10 times, most recently from 3267c4e to fbcbf16 Compare February 23, 2026 18:50

LEGIO-SEXTA-FERRATA added 3 commits February 23, 2026 21:02

Migrate the repository to React 19 & React Native 0.78.2

b03df51

Fix GW tests

45fa318

Adjust migration script

6dbe1d4

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch from fbcbf16 to f943346 Compare February 23, 2026 20:07

weirdwater reviewed Feb 24, 2026

View reviewed changes

packages/pluggable-widgets-tools/configs/tsconfig.base.json Show resolved Hide resolved

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch 6 times, most recently from b96d27b to ac0c413 Compare February 25, 2026 13:42

alihcsumer reviewed Feb 25, 2026

View reviewed changes

packages/pluggable-widgets-tools/utils/migration.js Outdated Show resolved Hide resolved

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch from ac0c413 to 7db5d26 Compare February 25, 2026 13:51

LEGIO-SEXTA-FERRATA changed the title ~~[WTF] TEST~~ [WTF] Migrate The Repository to React 19 & React Native 0.78.2 Feb 25, 2026

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch 2 times, most recently from 845fdc9 to cf30484 Compare February 25, 2026 13:59

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch from cf30484 to 0c07706 Compare February 25, 2026 14:19

alihcsumer reviewed Feb 25, 2026

View reviewed changes

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch 2 times, most recently from 002e3b7 to 194afb2 Compare February 25, 2026 14:48

alihcsumer force-pushed the wtf/react-19-native branch from 194afb2 to d497c1b Compare February 25, 2026 16:02

LEGIO-SEXTA-FERRATA and others added 6 commits February 26, 2026 15:50

Deprecate the generation tests for Mendix 8

7115755

Remove the now unnecessary createElement import for JSX files

631681f

Adjust the migration script to handle the createElement imports that …

f1615ff

…will become unused

Use babel eslint parser

4e6f724

Activate a repository test line for node 20

345cf7d

Adjust dependencies for createElement cleanup routine

c177af5

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch from 6f416e3 to c177af5 Compare February 26, 2026 14:50

LEGIO-SEXTA-FERRATA added 3 commits February 26, 2026 16:04

Disable Node 16 test line

2306679

Remove the deprecated ban-types rule

67975bd

Ease the no require rule to a warning

163844c

LEGIO-SEXTA-FERRATA force-pushed the wtf/react-19-native branch from 0e178da to 163844c Compare February 26, 2026 16:31

weirdwater requested changes Feb 27, 2026

View reviewed changes

weirdwater mentioned this pull request Feb 27, 2026

[MOO-2205] Update RN version to 0.78.2 #160

Closed

Conversation

LEGIO-SEXTA-FERRATA commented Feb 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

weirdwater commented Feb 27, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

LEGIO-SEXTA-FERRATA commented Feb 17, 2026 •

edited

Loading