toolkit/app-gen-toc.py: Remove updateDeviceConfig() function.#9
toolkit/app-gen-toc.py: Remove updateDeviceConfig() function.#9dpgeorge wants to merge 1 commit intowork-v1.104.0from
Conversation
It doesn't do anything except give an error if the config file contains certain entries. There's no harm having these entries there, so just skip the validation altogether. Signed-off-by: Damien George <damien@micropython.org>
I didn't actually read what the original script did, so I missed that it removed those items. Could it be removing them because the SE can't handle them, or just to save space? If the SE can't handle them, it's probably best to leave them out somehow by removing them from the loaded config (if it's loaded at some point) or just leaving the error as it is. I've never actually tested running a config that includes these items so not sure if it works with them included. |
|
Apparently they're removed because the SE doesn't make any use of them,and they have no effect on the binary output, so it's probably fine to leave them or remove them if you like. |
OK so the options are:
I think option (2) is fine. |
It doesn't do anything except give an error if the config file contains certain entries. There's no harm having these entries there, so just skip the validation altogether.