Skip to content

Conversation

@liunick-msft
Copy link
Contributor

This pull request introduces significant improvements and refactoring to the Dell EMC OS10 configuration templates, interface definitions, and supporting documentation for the network configuration generator tool. The main focus is on enhancing MLAG/VLT support, refining BGP and port-channel configurations, updating interface templates, and improving documentation for clarity and usability.

Template and Configuration Enhancements

  • Added a new Jinja2 template vlt.j2 for Dell EMC OS10 switches to generate VLT (Virtual Link Trunking) configuration dynamically based on MLAG peer links and iBGP peer IPs. This is now included in the full OS10 configuration (full_config.j2). [1] [2]
  • Improved BGP configuration in bgp.j2 by splitting maximum-paths into ibgp and ebgp, adding next-hop-self, and removing unnecessary sender-side-loop-detection for better compatibility and stability. [1] [2] [3]
  • Enhanced port-channel configuration logic in port_channel.j2 to properly handle VLT peer-links, L3/trunk types, member interface settings, and conditional no switchport for specific peer-link scenarios. [1] [2] [3]
  • Updated interface.j2 to support MLAG peer link interfaces, add security notes for shutdown ports, and ensure proper handling of interface ranges and types. [1] [2]

Input Data and Documentation Updates

  • Modified switch interface templates (N3248TE-ON.json, s5248f-on.json) to add MLAG peer links, update interface definitions, and reorganize trunk/access groups for more accurate and flexible configuration generation. [1] [2] [3] [4] [5]
  • Improved documentation in README.md to clarify parameter defaults, usage examples, and converter options; updated directory structure to reflect new files and modules. [1] [2]

System and SNMP Configuration

  • Added SNMP and VRRP configuration blocks to system.j2 for Dell EMC OS10, including conditional VRRP settings for non-BMC switches, management VRF, and SNMP community/location/contact fields. [1] [2]

Dev Environment and Build Process Clean-up

  • Removed unused devcontainer files (Dockerfile, devcontainer.json) and PyInstaller hook for convertors to streamline development and packaging. Also simplified PyInstaller build steps in the GitHub workflow. [1] [2] [3] [4] [5]

@liunick-msft liunick-msft merged commit 3478dfe into main Dec 9, 2025
6 checks passed
@liunick-msft liunick-msft deleted the dev/nl/optimize_structure branch December 9, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants