Draft
Conversation
akrieger
reviewed
Feb 23, 2026
Comment on lines
+62
to
+64
| // Touch first and last bytes to ensure pages are faulted in | ||
| p[0] = 1; | ||
| p[ALLOC_SIZE - 1] = 1; |
There was a problem hiding this comment.
If I understand correctly, Windows will only faults in touched pages and not the entire range. I don't know the behavior for other kernels but that's what the documention I can find says https://learn.microsoft.com/en-us/windows/win32/memory/reserving-and-committing-memory "... As an alternative to dynamic allocation, the process can simply commit the entire region instead of only reserving it. Both methods result in the same physical memory usage because committed pages do not consume any physical storage until they are first accessed."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reapplies the DecayRange PR to the latest version of snmalloc. It also
This is a very draft PR with a lot of reviewing of AI refactorings required.
This might increase footprint considerably, and care is needed to configure who it operates precisely.