Remove onExp tag from native locator experiment #25258
Closed
cwebster-99 wants to merge 1 commit intomainfrom
Closed
Remove onExp tag from native locator experiment #25258cwebster-99 wants to merge 1 commit intomainfrom
cwebster-99 wants to merge 1 commit intomainfrom
Conversation
cwebster-99
added
the
debt
eleanorjboyd
added
the
skip package*.json
eleanorjboyd
approved these changes
Jul 8, 2025
Member
eleanorjboyd
left a comment
eleanorjboyd
left a comment
There was a problem hiding this comment.
will defer to @karthiknadig on if it should have the preview tag still or not
Member
|
We can remove it. This has been out for a while. |
karthiknadig
force-pushed
the
victorious-reindeer
branch
from
c97ed39 to
0399549
Compare
karthiknadig
approved these changes
Aug 19, 2025
Member
|
Moved this to September |
Member
|
I looked into why this keeps failing smoketests. We don't include a binary that we need into the build when doing smoke tests. This requires a greater fix. |
auto-merge was automatically disabled
September 10, 2025 18:44
Pull request was closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the
python.locatorconfiguration inpackage.jsonto change its default value and removeonExpandpreviewtags.