Skip to content

Comments

update to node 22.17.0#25378

Closed
eleanorjboyd wants to merge 5 commits intomicrosoft:mainfrom
eleanorjboyd:angry-anteater
Closed

update to node 22.17.0#25378
eleanorjboyd wants to merge 5 commits intomicrosoft:mainfrom
eleanorjboyd:angry-anteater

Conversation

@eleanorjboyd
Copy link
Member

@eleanorjboyd eleanorjboyd commented Aug 11, 2025

No description provided.

@eleanorjboyd eleanorjboyd self-assigned this Aug 11, 2025
@eleanorjboyd eleanorjboyd added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary skip-issue-check labels Aug 11, 2025
@vs-code-engineering
Copy link

vs-code-engineering bot commented Aug 11, 2025

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@vs-code-engineering vs-code-engineering bot added this to the August 2025 milestone Aug 11, 2025
Tyriar
Tyriar previously approved these changes Aug 11, 2025
View reviewed changes
@vs-code-engineering
Copy link

vs-code-engineering bot commented Aug 11, 2025

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

Tyriar
Tyriar previously approved these changes Aug 11, 2025
View reviewed changes
@vs-code-engineering
Copy link

vs-code-engineering bot commented Aug 11, 2025

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@eleanorjboyd
Copy link
Member Author

eleanorjboyd commented Aug 11, 2025

@karthiknadig could use your help here, not sure the point of the few tests I had to edit as I updated node:

Is the correct behavior to keeping command paths intact for accuracy while making working directory paths more readable by showing them relative to the workspace?

rzhao271
rzhao271 previously approved these changes Aug 11, 2025
View reviewed changes
@karthiknadig
Copy link
Member

karthiknadig commented Aug 11, 2025

@eleanorjboyd We were doing this to make it easier for users to copy paste the logs.

Is the correct behavior to keeping command paths intact for accuracy while making working directory paths more readable by showing them relative to the workspace?

yes, that is correct.

@vs-code-engineering
Copy link

vs-code-engineering bot commented Aug 11, 2025

⚠️ This PR originates from a fork. Due to security restrictions, pipelines from forks are no longer triggered automatically. Learn more.

If the changes appear safe, you can manually trigger the pipeline by commenting /AzurePipelines run.

@eleanorjboyd
Copy link
Member Author

eleanorjboyd commented Aug 12, 2025

sorry for all the notifications everyone, switching to a new PR to try things and have it be less noisy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rzhao271 rzhao271 rzhao271 approved these changes

@Tyriar Tyriar Tyriar left review comments

Assignees

@eleanorjboyd eleanorjboyd

Labels

debt Covers everything internal: CI, testing, refactoring of the codebase, etc. skip tests Updates to tests unnecessary skip-issue-check

Projects

None yet

Milestone

August 2025

Development

Successfully merging this pull request may close these issues.

4 participants

@eleanorjboyd @karthiknadig @Tyriar @rzhao271