Add chat extension custom URI to allowed schemes for rendering #291455
+81
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for the copilot-skill URI scheme to be rendered in chat markdown content without being sanitized away.
Changes:
- Added new
copilotSkillconstant to theSchemasnamespace for thecopilot-skillURI scheme - Included
Schemas.copilotSkillin the list of allowed link schemes for chat markdown rendering
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/vs/base/common/network.ts | Added new copilotSkill scheme constant with documentation |
| src/vs/workbench/contrib/chat/browser/widget/chatContentMarkdownRenderer.ts | Added import for Schemas and included copilotSkill in allowed link schemes |
zhichli
previously approved these changes
Jan 29, 2026
Member
Author
|
@mjbvz let me know if this change looks reasonable to you. Thanks! |
Contributor
|
The solution seems to be to specific to prompt files. The workspace can be opened on a virtual filesystem, we use virtual file systems for many things: For DOM sanitize, can we not just allow '*'? My understanding is that in the end it's our opener that opens the editor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: extension-provided URIs can use virtual file systems. URI scheme check currently rejects those, but we don't want to remove this check. I think we can just check if the files were extension-contributed.