-
Notifications
You must be signed in to change notification settings - Fork 37.6k
engineering: use tar+zstd for win32 node_modules cache #291624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR replaces 7-Zip compression with tar+zstd for Windows node_modules caching to significantly improve CI/CD performance. According to the PR description, this reduces the Extract node_modules phase from 120-180 seconds to 60 seconds. Both tar.exe and zstandard are bundled in GitHub Actions and Azure Pipelines Windows images, making this change feasible without additional tooling requirements.
Changes:
- Replaced all 7z.exe commands with tar+zstd commands across GitHub Actions and Azure Pipelines workflows
- Changed cache file extension from
.7zto.tzst - Updated
.cachesalttimestamp to invalidate existing caches
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/pr-win32-test.yml |
Updated extraction and creation commands to use tar+zstd instead of 7z |
.github/workflows/pr-node-modules.yml |
Updated Windows job creation command to use tar+zstd instead of 7z |
build/azure-pipelines/win32/steps/product-build-win32-compile.yml |
Updated extraction and creation commands to use tar+zstd instead of 7z |
build/azure-pipelines/win32/product-build-win32-node-modules.yml |
Updated creation command to use tar+zstd instead of 7z |
build/.cachesalt |
Bumped timestamp to invalidate old 7z-based caches |
|
This change broke CI for #291731. Reverting. |
…)" This reverts commit 7052972.
from @tmm1: