Use INSTALLDIR as install location switch for WiX installers#2671
Open
SpecterShell wants to merge 2 commits intomicrosoft:masterfrom
Open
Use INSTALLDIR as install location switch for WiX installers#2671SpecterShell wants to merge 2 commits intomicrosoft:masterfrom
SpecterShell wants to merge 2 commits intomicrosoft:masterfrom
Conversation
sharunkumar
reviewed
Sep 12, 2023
Comment on lines
+559
to
+565
| return | ||
| { | ||
| {InstallerSwitchType::Silent, ManifestInstaller::string_t("/quiet /norestart")}, | ||
| {InstallerSwitchType::SilentWithProgress, ManifestInstaller::string_t("/passive /norestart")}, | ||
| {InstallerSwitchType::Log, ManifestInstaller::string_t("/log \"" + std::string(ARG_TOKEN_LOGPATH) + "\"")}, | ||
| {InstallerSwitchType::InstallLocation, ManifestInstaller::string_t("INSTALLDIR=\"" + std::string(ARG_TOKEN_INSTALLPATH) + "\"")} | ||
| }; |
There was a problem hiding this comment.
previously, InstallerTypeEnum::Burn case would fallthrough to InstallerTypeEnum::Msi, but now is going to fallthrough to this code? 🤔
Contributor
|
@SpecterShell - I'm assuming this will need to be rebased and/or have the merge conflicts resolved, if this is something which you still want to raise the PR for |
Contributor
Author
|
Among all the MSI installers I have processed so far, some of them use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-l,--locationoption not working on all msi packages #1857MSI installers built by WiX Toolset use different switches such as
INSTALLDIRinstead ofTARGETDIRas install location parameter. While adding new packages and reworking old packages, I noticed that most WiX installers are usingINSTALLDIR. I felt that it is necessary to replace the current install location switch withINSTALLDIRsince some new building toolchains like Tauri Builder are using WiX as the default installer builder, where developers are less likely to modify the WiX template and don't know what switches should be used for WinGet manifest.However, the custom location switch may vary among WiX installers according to #1857 (comment). In case of potential conner cases, I will draft this PR and look into the remaining packages in winget-pkgs repo to see the proportion of switches they are using.
Some of the conner cases:
INSTALLLOCATIONLiErHeXun.QuickerMicrosoft Reviewers: Open in CodeFlow