Add filter-by install scope (user/machine) for List and Search#6044
Add filter-by install scope (user/machine) for List and Search#6044IDisposable wants to merge 1 commit intomicrosoft:masterfrom
Conversation
This comment has been minimized.
This comment has been minimized.
IDisposable
force-pushed
the
feature/more-filters
branch
from
0e6ba61 to
a30f1aa
Compare
This comment has been minimized.
This comment has been minimized.
Also fix the filter-by source for List to work. Added parameter to Get-WinGetPackage for install scope and pass it down to the filters sent to WinGet CLI.
IDisposable
force-pushed
the
feature/more-filters
branch
from
a30f1aa to
51b06c9
Compare
Oops, fixed and force-pushed |
JohnMcPMS
left a comment
JohnMcPMS
left a comment
There was a problem hiding this comment.
There is no actual change to behavior presented here (save potential improvements to completion). Filtering by scope is already present on list and adding it to search will require significant investment, including placing the scope into the index.
Filtering the list output based on the source parameter is achievable with a client only change, but this PR doesn't actually do what is needed.
|
|
||
| ## Bug Fixes | ||
|
|
||
| > 1. Prior to this version, it was permitted to provide a `--source` filter for the `winget list` command, however the parameter was ignored. Now if a filter is provided packages will be check before being returned from the `winget list` command. |
There was a problem hiding this comment.
| > 1. Prior to this version, it was permitted to provide a `--source` filter for the `winget list` command, however the parameter was ignored. Now if a filter is provided packages will be check before being returned from the `winget list` command. | |
| > 1. Prior to this version, it was permitted to provide a `--source` filter for the `winget list` command, however the parameter was used only to limit the sources to correlate with. Now, if a filter is provided, packages will be filtered before being output from the `winget list` command. |
This is false; the parameter was used inconsistently from how it would seem most people expected (but very consistently with the rest of the command workflows).
There was a problem hiding this comment.
When calling the Powershell API, it sure doesn't seem to filter by scope. My goal is to find all the user-scoped, winget-installed packages and reinstall them as machine-scoped if possible. Trying to script in Powershell...
| Argument::ForType(Execution::Args::Type::Tag), | ||
| Argument::ForType(Execution::Args::Type::Command), | ||
| Argument::ForType(Execution::Args::Type::Source), | ||
| Argument{ Execution::Args::Type::InstallScope, Resource::String::InstalledScopeArgumentDescription, ArgumentType::Standard, Argument::Visibility::Help }, |
There was a problem hiding this comment.
| Argument{ Execution::Args::Type::InstallScope, Resource::String::InstalledScopeArgumentDescription, ArgumentType::Standard, Argument::Visibility::Help }, | |
| Argument{ Execution::Args::Type::InstallScope, Resource::String::InstallScopeDescription, ArgumentType::Standard, Argument::Visibility::Help }, |
Additionally, just accepting the parameter is unlikely to have the desired effect on the downstream workflow. search in particular intentionally avoids accessing the manifest, which is currently the only way to know available scopes and thus filter the results.
There was a problem hiding this comment.
Fair point. I was really only concerned with pulling a list to make an script to do an automated "user" to "machine" reinstall. I'll pull the search changes :)
| } | ||
|
|
||
| Export-ModuleMember -Function Get-WinGetPackage No newline at end of file | ||
| Function Get-WinGetPackage{ |
There was a problem hiding this comment.
This file is not used; the PowerShell is all C# in \src\PowerShell.
There was a problem hiding this comment.
Seems like that should be removed then? Seems really confusing.
|
|
||
| # New Feature: Filter List and Search command by install scope | ||
|
|
||
| This adds the ability to filter the list returned by the `winget list` and `winget search` commands by the install scope |
microsoft-github-policy-service
bot
added
Needs-Author-Feedback
What, beyond doing the same logic as the source is needed? https://github.com/microsoft/winget-cli/pull/6044/changes#diff-2cf6f75aa8aad569ed10c9f32e985e9348f431490438e7361d4a484c80050dceR66 |
2 participants
Fixes #6045 and Implements #4236 (summarized in #1155), #6046, and #6047
Microsoft Reviewers: Open in CodeFlow