FIX: correct sensor name ordering in plot_topomap when using Info object#13686
Open
Famous077 wants to merge 7 commits intomne-tools:mainfrom
Open
FIX: correct sensor name ordering in plot_topomap when using Info object#13686Famous077 wants to merge 7 commits intomne-tools:mainfrom
Famous077 wants to merge 7 commits intomne-tools:mainfrom
Conversation
Famous077
requested review from
agramfort,
drammock and
larsoner
as code owners
for more information, see https://pre-commit.ci
Author
|
Hi @agramfort , Would appreciate your review when you get a chance. Happy to update based on your feedbac.k. Thank you |
…mous077/mne-python into fix/plot-topomap-sensor-names
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference issue (if any)
What does this implement/fix?
--> When passing an Info object as pos to mne.viz.plot_topomap() with the
names argument, the sensor names were not reordered to match the
reordered channel positions. This caused a mismatch between displayed
names and their actual positions on the topomap.
The fix reorders the names array to match the picks ordering when:
Additional information
--> The data values were always correct , only the displayed sensor names
were mismatched. The fix is minimal and targeted, only affecting the
names reordering when pos is an Info object.