Fix grammar errors in apps.mdx#300
Open
glen-84 wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
Conversation
ochafik
reviewed
Jan 21, 2026
| { | ||
| jsonrpc: "2.0", | ||
| method: "ui/notifications/tool-cancelled", | ||
| method: "ui/notifications/tool-canceled", |
Contributor
There was a problem hiding this comment.
Unfortunately this would be a breaking change / needs type update (probably not happening before first non-draft version at this point)
Collaborator
There was a problem hiding this comment.
Both are valid, so I'm not sure this must be changed.
Author
There was a problem hiding this comment.
I'm not American myself, but most technical literature is written in US English.
The specification is using words like color and behavior, which is US English, so it might be best not to mix US and non-US English.
I noted the breaking change in the OP. If you decide to make the change, it would surely be easier to do that now with the draft version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Improved grammar and consistency.
How Has This Been Tested?
n/a
Breaking Changes
Yes, the
ui/notifications/tool-cancelledevent is now namedui/notifications/tool-canceled.Types of changes
Checklist
Additional context
cancelledis spelledcanceledin US English.