[Server] Add autoload check for enum types in ReferenceHandler#225
Open
joshuatam wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
[Server] Add autoload check for enum types in ReferenceHandler#225joshuatam wants to merge 1 commit intomodelcontextprotocol:mainfrom
joshuatam wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
Some old framework is using autoload to include with the typeName directly, e.g. `include(ini.php)` when the typeName is `ini`. If the typeName is the arbitrary type, set autoload in `enum_exists` to `false`
Member
|
Hey @joshuatam, thanks for reaching out and bringing the patch. Can you help me understand the issue here? What's happening without this patch? |
Author
I am integrating the sdk with Yii1, in which it will throw an error when reading Elements classes, e.g. And the error is |
Member
|
I'm really not sure that this is an error on library side, but rather something your autoloader should catch? are you using composer or sth custom? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Some old framework is using autoload to include with the typeName directly, e.g.
include(ini.php)when the typeName isini.If the typeName is the arbitrary type, set autoload in
enum_existstofalseHow Has This Been Tested?
Yes
Breaking Changes
No
Types of changes
Checklist
Additional context
None