Avoiding to parse string arguments containing valid JSON if the argument annotation is str#1113
Merged
bhosmer-ant merged 1 commit intomodelcontextprotocol:mainfrom Jul 10, 2025
cjg:main
Merged
Avoiding to parse string arguments containing valid JSON if the argument annotation is str#1113bhosmer-ant merged 1 commit intomodelcontextprotocol:mainfrom cjg:main
bhosmer-ant merged 1 commit intomodelcontextprotocol:mainfrom
cjg:main
Conversation
…ent annotation is str, fixes #1112
bhosmer-ant
approved these changes
Jul 10, 2025
Contributor
bhosmer-ant
left a comment
There was a problem hiding this comment.
@cjg thank you for this!
0a4e8d4
into
modelcontextprotocol:main
19 of 20 checks passed
9 tasks
ihrpr
pushed a commit
that referenced
this pull request
Jul 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every time a parameter of a tool is passed as a string containing a valid JSON it is parsed and replaced. From the comment of pre_parse_json() "This is to handle cases like
["a", "b", "c"]being passed in as JSON inside a string rather than an actual list"Nevertheless this method doesn't check if the annotation of parameters indicates that it is supposed to be a str rather than a dict or a list
Types of changes
Checklist