feat: add support for disabling output validation for tools#1189
feat: add support for disabling output validation for tools#1189antoniomdk wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
65c9d54 to
1637b70
Compare
felixweinberger
left a comment
There was a problem hiding this comment.
Hi @antoniomdk thank you for this contribution! And apologies for the time it took to get back to you on this one.
I understand the motivation here that you want to be able to rely on downstream validation when it's available and skip validation here.
However I believe this would allow some hard to discover bugs when turning validation off. If the SDK provides structured output as an option, it should also ensure that it is indeed conforming to it regardless of what might be happening downstream.
I believe the computational cost is negligible compared to the safety we have of being internally confident that the output is valid as defined by the schema.
I'm therefore going to close this PR, but if you have additional motivation or examples where this is unreasonably costly, keen to understand your use case!
Motivation and Context
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context