Make errlog optional in stdio_client and update default to None#1807
Open
sesajad wants to merge 3 commits intomodelcontextprotocol:mainfrom
Open
Make errlog optional in stdio_client and update default to None#1807sesajad wants to merge 3 commits intomodelcontextprotocol:mainfrom
errlog optional in stdio_client and update default to None#1807sesajad wants to merge 3 commits intomodelcontextprotocol:mainfrom
Conversation
f157245 to
d08e585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have modified the input type of the
errlogparameter instdio_clientfromTextIOtoTextIO | None, and updated its default value fromsys.stderrtoNone.Furthermore, I have included a server that generates both logging and
stderrprints, along with a client demonstrating how to capture each type of log from the server.Motivation and Context
Discussed in #1806
How Has This Been Tested?
Testing was conducted by executing
examples/snippets/clients/logging_client.pywith varying values forerrlog.Breaking Changes
All MCP stdio clients that previously relied on
stderrlogs being piped to the processstderrwill now need to modify their calls:to
Types of changes
Checklist
Additional context
None