fix: handle_sse_response causing dangling client's read_stream #1812
Open
ivanbelenky wants to merge 2 commits intomodelcontextprotocol:mainfrom
Open
fix: handle_sse_response causing dangling client's read_stream #1812ivanbelenky wants to merge 2 commits intomodelcontextprotocol:mainfrom
handle_sse_response causing dangling client's read_stream #1812ivanbelenky wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
handle_sse_response causing dangling client's read_stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notifying session layer on transport error. Sending the error to the client's
read_stream_writer.Motivation and Context
Indefinitely hang described on issue #1811
How Has This Been Tested?
Running suite of tests locally as per contribution guidelines.
Breaking Changes
Types of changes
Checklist
Additional context