fix(ci): use bash shell for pytest step to ensure consistent error handling#1868
Merged
fix(ci): use bash shell for pytest step to ensure consistent error handling#1868
Conversation
…ndling On Windows, PowerShell doesn't stop on first error by default. When pytest fails, PowerShell continues to run coverage combine/report, and if those succeed, the step exits with code 0 (appearing to pass). Using 'shell: bash' ensures consistent behavior across platforms - bash's set -e stops execution on the first failed command. Claude-Generated-By: Claude Code (cli/claude-opus-4-5=100%) Claude-Steers: 4 Claude-Permission-Prompts: 4 Claude-Escapes: 0
Kludex
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes inconsistent CI behavior where Windows tests appeared to pass even when pytest failed.
Problem
The pytest step runs multiple commands:
On Linux (bash): When pytest fails, bash's
set -estops execution immediately → step exits with code 1 → marked as failed.On Windows (PowerShell): PowerShell doesn't stop on first error by default. When pytest fails, it continues to run
coverage combineandcoverage report. Since the last command succeeds → step exits with code 0 → marked as passed (incorrectly).Solution
Add
shell: bashto the pytest step. Bash is available on Windows runners in GitHub Actions and provides consistent error handling behavior across platforms.