refactor: introduce MCPModel base class for protocol types#1880
Merged
Conversation
Add MCPModel base class that inherits from Pydantic BaseModel with `extra="allow"` configuration for forward compatibility with protocol extensions. This change: - Creates MCPModel as a central base class for all MCP protocol types - Updates all protocol types to inherit from MCPModel (directly or indirectly) - Removes redundant model_config declarations from ~80 classes - Maintains the same runtime behavior while reducing code duplication The MCPModel pattern centralizes the `extra="allow"` configuration that enables MCP protocol types to accept additional fields not defined in the schema, which is essential for forward compatibility with future protocol versions. Co-authored-by: Max Isbey <224885523+maxisbey@users.noreply.github.com>
Kludex
force-pushed
the
refactor/mcp-model-base-class
branch
from
b753864 to
518a10f
Compare
maxisbey
approved these changes
Jan 16, 2026
maxisbey
approved these changes
Jan 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.