Merged
Conversation
pcarleton
previously approved these changes
May 20, 2025
Member
pcarleton
left a comment
pcarleton
left a comment
There was a problem hiding this comment.
LGTM
Tested against the python example:
uv run mcp-simple-auth --transport sse
MCP_SERVER_URL=http://localhost:8000/sse MCP_TRANSPORT_TYPE=sse uv run mcp-simple-auth-client
Member
There was a problem hiding this comment.
nit: might change this to be /sse if the transport is set since that's the default binding we get. might get a little funky making sure you don't overwrite it though.
https://github.com/modelcontextprotocol/python-sdk/blob/main/src/mcp/server/fastmcp/server.py#L93
Contributor
Author
There was a problem hiding this comment.
hmm, something is weird, I thought I changed that to port!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar to Streamable Http Auth client added in #751 adding auth to SSE.
Testing
SSE
Check that StreamableHttp works: