update schema url point to the actual location#884
update schema url point to the actual location#884tadasant merged 1 commit intomodelcontextprotocol:mainfrom
Conversation
tadasant
left a comment
There was a problem hiding this comment.
Thanks for jumping in on this!
| "$schema": { | ||
| "description": "JSON Schema URI for this server.json format", | ||
| "example": "https://static.modelcontextprotocol.io/schemas/2025-12-11/server.schema.json", | ||
| "example": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json", |
There was a problem hiding this comment.
Let's keep the example the static. URL since that is more representative of what should live here
There was a problem hiding this comment.
Reverted back to the static schema URL in the example field . Auto-generated after updating the openapi.yaml spec
docs/reference/api/openapi.yaml
Outdated
| format: uri | ||
| description: JSON Schema URI for this server.json format | ||
| example: "https://static.modelcontextprotocol.io/schemas/2025-12-11/server.schema.json" | ||
| example: "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json" |
There was a problem hiding this comment.
Reverted back to the static schema URL in the example field .
| { | ||
| "$comment": "This file is auto-generated from docs/reference/api/openapi.yaml. Do not edit manually. Run 'make generate-schema' to update.", | ||
| "$id": "https://static.modelcontextprotocol.io/schemas/draft/server.schema.json", | ||
| "$id": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json", |
There was a problem hiding this comment.
| "$id": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/server.schema.json", | |
| "$id": "https://raw.githubusercontent.com/modelcontextprotocol/registry/main/docs/reference/server-json/draft/server.schema.json", |
Just for clarity, I think we should preserve draft in the ID; which means we should move the file inside a folder called draft
There was a problem hiding this comment.
Moved the server.schema.json file to the draft directory . Made necessary changes to schemaOutputDir and schemaID in the tools/extract-server-schema/main.go file .
8b343da to
2eadc5b
Compare
|
I had Claude do a first pass at reviewing (see summary below) -- I haven't had the chance to dig in and verify its findings yet, but would appreciate help ensuring we're not missing things here. 2. Missing file references that should be updated Several documentation files still reference
These relative links will break after the file is moved to
Edit: I just took a closer look and it appears (3) was not helpful but at least (2) seems right (we should update those references). Can you please do another pass making sure we haven't missed other references? |
2eadc5b to
9be0ebf
Compare
|
@tadasant I have updated the references in the files that you have highlighted above and also in few other files :
|
9be0ebf to
016b231
Compare
5e4a9f4 to
8958ea2
Compare
|
@rdimitrov merge conflict resolved by rebasing with the main branch |
Motivation and Context
This PR ensures that the draft URL points to the actual draft schema
improvement suggested in #814
How Has This Been Tested?
Breaking Changes
Types of changes
Checklist
Additional context