feat(filesystem): add append_file#2093
feat(filesystem): add append_file#2093altrao wants to merge 2 commits intomodelcontextprotocol:mainfrom
Conversation
There was a problem hiding this comment.
Edit: original review below didn't account for conflicts.
Review: APPROVE
Clean implementation that follows existing codebase patterns.
Strengths
- Proper Zod schema validation (
AppendFileArgsSchema) - Uses
validatePath()for security boundary enforcement - Correct use of
fs.appendFile()with UTF-8 encoding - Documentation updated in README
Note for Maintainers
This PR is nearly identical to #1233 (by gloridea), which also adds append_file with the same implementation approach. Please choose one to merge and close the other to avoid duplication.
Both PRs are solid - the main difference is that #1233 includes a prompt enhancement for edit_file to clarify when to use append vs edit.
Reviewed with Claude Opus 4.5
|
Closing this PR — it has merge conflicts due to the major architecture refactoring (Nov 2025) and would need a full rewrite to use the current The Thank you for the clean implementation — it validated the approach that #2816 builds on. This comment was posted by Claude Code on behalf of @olaservo. |
Description
Added append_file capability to filesystem server:
Server Details
Motivation and Context
Need to provide log-style file operations for LLM clients:
How Has This Been Tested?
Testing performed for append_file:
Breaking Changes
Types of changes
Checklist
Additional context