Update Everything server's elicitation request#3097
Merged
olaservo merged 4 commits intomodelcontextprotocol:mainfrom Dec 12, 2025
Merged
Update Everything server's elicitation request#3097olaservo merged 4 commits intomodelcontextprotocol:mainfrom
olaservo merged 4 commits intomodelcontextprotocol:mainfrom
Conversation
* In everything.ts
- In elcitiation request,
- Update all fields to have a title property
- Add all 5 enum types supported by the SDK
- legacy titled single select
- titled single select
- titled multi select
- untitled single select
- untitled multi select
- Use faux ids (e.g., hero-1, hero-2) for enum value when titled to illustrate the difference.
17 tasks
olaservo
previously approved these changes
Dec 10, 2025
Member
olaservo
left a comment
There was a problem hiding this comment.
Besides the small typos, this looks good to me and is working with the Inspector from your branch. 👍
Member
|
Just noticed, do we need to update the Readme? |
olaservo
approved these changes
Dec 10, 2025
olaservo
requested changes
Dec 10, 2025
Member
olaservo
left a comment
There was a problem hiding this comment.
Sorry, meant to click request changes for minor issues.
Co-authored-by: Ola Hungerford <olahungerford@gmail.com>
Co-authored-by: Ola Hungerford <olahungerford@gmail.com>
olaservo
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for all enum types in new MCP spec by updating the Elicitation request which asks for all the supported data types.
Changes
Server Details
Motivation and Context
SEP-1330 made the previous style of enum schema legacy since it doesn't follow the JSON schema for adding titles to enums. It adds a proper schema for titled enum and also select and multi select variations. All told, there are 5 ways you can define an enum now, depending upon your needs.
How Has This Been Tested?
Using this PR added to the Inspector, which supports all the enum types.
Related issues
#3041
Breaking Changes
Yes. Clients that do not use the new version of the spec will ignore these fields.
We should do a follow-on PR (or in the rebuild of this server) and pass the negotiated protocol version to the everything server so that it can omit these fields unless the latest version is supported.
Types of changes
Checklist
Additional context
For more on the various enum types now supported by the protocol, see SEP-1330